Skip to content

datajoint python CLI#1095

Closed
A-Baji wants to merge 10 commits intodatajoint:masterfrom
A-Baji:dj-cli
Closed

datajoint python CLI#1095
A-Baji wants to merge 10 commits intodatajoint:masterfrom
A-Baji:dj-cli

Conversation

@A-Baji
Copy link
Collaborator

@A-Baji A-Baji commented Jun 22, 2023 •
edited
Loading

Examples:

vscode ➜ /workspaces/datajoint-python (dj-cli) $ dj
dj repl

>>> dj.config
{   'connection.charset': '',
    'connection.init_function': None,
    'database.host': 'fakeservices.datajoint.io',
    'database.password': 'simple',
    'database.port': 3306,
    'database.reconnect': True,
    'database.use_tls': None,
    'database.user': 'root',
    'display.limit': 12,
    'display.show_tuple_count': True,
    'display.width': 14,
    'enable_python_native_blobs': True,
    'fetch_format': 'array',
    'filepath_checksum_size_limit': None,
    'loglevel': 'INFO',
    'safemode': True}
>>> 

vscode ➜ /workspaces/datajoint-python (dj-cli) $ datajoint -u test_user -p test_password -h test_host
dj repl

>>> print(dj.config['database.user'],dj.config['database.password'],dj.config['database.host'])
test_user test_password test_host
>>> 

vscode ➜ /workspaces/datajoint-python (dj-cli) $ dj -s djtest_test1:test1 djtest_relational:relational
[2023-06-22 17:35:08,925][INFO]: Connecting root@fakeservices.datajoint.io:3306
[2023-06-22 17:35:08,930][INFO]: Connected root@fakeservices.datajoint.io:3306
dj repl

schema modules:

  - test1
  - relational

>>> test1.TTest()
*key    value    
+-----+ +-------+
0       0        
1       2        
2       4        
3       6        
4       8        
5       10       
6       12       
7       14       
8       16       
9       18       
 (Total: 10)

>>>

@A-Baji A-Baji linked an issue Jun 22, 2023 that may be closed by this pull request
DataJoint CLI / launcher script #940
Closed
@A-Baji A-Baji requested a review from dimitri-yatsenko June 22, 2023 18:16
dimitri-yatsenko
dimitri-yatsenko approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it, although the documentation is still pending.

@ethho
Copy link
Contributor

ethho commented Sep 12, 2024

@dimitri-yatsenko This needs to merge in master branch.

ethho
ethho reviewed Sep 12, 2024
View reviewed changes
tests/test_cli.py
import subprocess
import pytest
import datajoint as dj
from . import CONN_INFO_ROOT, PREFIX
Copy link
Contributor

@ethho ethho Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytests not working in Dev Container with new pytest framework. Will need to migrate dependencies like CONN_INFO_ROOT to the respective pytest.fixtures.

vscode ➜ /workspaces/datajoint-python (hidden-1091-continued) $ pytest tests/test_cli.py
========================================================= test session starts ==========================================================
platform linux -- Python 3.11.4, pytest-8.2.2, pluggy-1.5.0
rootdir: /workspaces/datajoint-python
plugins: Faker-28.4.1, cov-5.0.0
collected 0 items / 1 error                                                                                                            

================================================================ ERRORS ================================================================
__________________________________________________ ERROR collecting tests/test_cli.py __________________________________________________
ImportError while importing test module '/workspaces/datajoint-python/tests/test_cli.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_cli.py:9: in <module>
    from . import CONN_INFO_ROOT, PREFIX
E   ImportError: cannot import name 'CONN_INFO_ROOT' from 'tests' (/workspaces/datajoint-python/tests/__init__.py)
======================================================= short test summary info ========================================================
ERROR tests/test_cli.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=========================================================== 1 error in 0.20s ===========================================================

ethho added a commit that referenced this pull request Sep 12, 2024
@ethho
Migrate tests from #1095 to pytest
53e81e3
@ethho ethho mentioned this pull request Sep 12, 2024
Merged
@ethho
Copy link
Contributor

ethho commented Sep 12, 2024

Continued development on #1181.

@ethho ethho closed this Sep 12, 2024
dimitri-yatsenko added a commit that referenced this pull request Sep 12, 2024
@dimitri-yatsenko
Merge pull request #1181 from datajoint/cli-1095-continued
f0d83a8 
DataJoint CLI continued (#1095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethho ethho ethho left review comments

@dimitri-yatsenko dimitri-yatsenko dimitri-yatsenko approved these changes

Assignees

@ethho ethho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataJoint CLI / launcher script

3 participants

@A-Baji @ethho @dimitri-yatsenko